chore: use attributes to define routes #2353
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2353 +/- ##
=======================================
Coverage ? 43.13%
Complexity ? 851
=======================================
Files ? 72
Lines ? 3162
Branches ? 0
=======================================
Hits ? 1364
Misses ? 1798
Partials ? 0 |
Chartman123
force-pushed
the
chore/use-route-attributes
branch
2 times, most recently
from
951b97d
to
68b1920
Compare
Chartman123
added
the
Do not merge
Chartman123
force-pushed
the
chore/use-route-attributes
branch
2 times, most recently
from
758f281
to
29fd096
Compare
Chartman123
added
3. to review
Chartman123
force-pushed
the
chore/use-route-attributes
branch
3 times, most recently
from
0199be5
to
30ba7c4
Compare
|
@susnux ready for review now :) |
susnux
reviewed
Oct 15, 2024
Chartman123
force-pushed
the
chore/use-route-attributes
branch
from
5f0a026
to
f9b71f7
Compare
Signed-off-by: Christian Hartmann <[email protected]>
Chartman123
force-pushed
the
chore/use-route-attributes
branch
from
f9b71f7
to
cd1fefb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant changes to the API routing and controller structure by centralizing constants and updating route definitions. The most important changes include moving the route definition from routes.php to the Controller attributes, and the introduction of constants for API base paths and requirements.
These changes enhance maintainability by centralizing configuration and leveraging modern PHP features for cleaner and more readable code.